VPC cleanup: use DestinationIpv6CidrBlock when available #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmorodskyi
force-pushed
the
cidr_block
branch
4 times, most recently
from
57a78db to
5fd7f8e
Compare
Closed
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #345 +/- ##
==========================================
- Coverage 78.81% 78.59% -0.22%
==========================================
Files 22 22
Lines 1647 1653 +6
==========================================
+ Hits 1298 1299 +1
- Misses 349 354 +5 ☔ View full report in Codecov by Sentry. |
asmorodskyi
force-pushed
the
cidr_block
branch
2 times, most recently
from
2596f36 to
c6eddf9
Compare
ricardobranco777
approved these changes
Jan 29, 2024
| azure-mgmt-resource==23.0.1 | ||
| azure-storage-blob==12.17.0 | ||
| azure-identity==1.14.0 | ||
| azure-mgmt-resource==23.1.0b2 |
There was a problem hiding this comment.
Are you sure you want to include a beta version?
There was a problem hiding this comment.
I gave you extend answer in PM . Here I will give short answer - it is choice of MS developers
pdostal
approved these changes
Jan 30, 2024
asmorodskyi
force-pushed
the
cidr_block
branch
from
c6eddf9 to
1557ff9
Compare
PR description updated please check if it is ok now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix exception
botocore.exceptions.ClientError: An error occurred (MissingParameter) when calling the DeleteRoute operation: The request must contain exactly one of: destinationCidrBlock, destinationIpv6CidrBlock, destinationPrefixListIdRelated ticket : https://progress.opensuse.org/issues/154456
NOTE : this PR contains 3 commits (commits 1 and 2 was added to fix failing CI) :
1.) upgrade selenium to fix pytest.PytestUnraisableExceptionWarning
2.) Switch to pip azure-cli install because azure-cli rpm not support python3.11
3.) VPC cleanup: use DestinationIpv6CidrBlock when available