Merge branch 'master' into akamai_cdn_migration

.github/workflows/lint-unit.yml

@@ -82,7 +82,12 @@ jobs:
       - name: Run core tests
         run: |
           bundle exec rake test:core
-        
+
+      - name: Run core tests with sqlite
+        run: |
+          sed -i 's/adapter: mysql2/adapter: sqlite3/' config/rmt.yml
+          bundle exec rake test:core
+          
       - name: Run PubCloud engines tests
         run: |
           bundle exec rake test:engines

spec/lib/rmt/cli/smt_importer_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 require 'rmt/cli/smt_importer'
 
-describe RMT::CLI::SMTImporter do
+describe RMT::CLI::SMTImporter, :skip_sqlite do
   let(:data_dir) { File.join(Dir.pwd, 'spec/fixtures/files/csv') }
   let(:no_systems) { false }
   let(:importer) { described_class.new(data_dir, no_systems) }

spec/lib/rmt/lockfile_spec.rb

@@ -3,7 +3,7 @@
 RSpec.describe RMT::Lockfile do
   let(:lock_name) { nil }
 
-  describe '#lock' do
+  describe '#lock', :skip_sqlite do
     subject(:lock) { described_class.lock(lock_name) { nil } }
 
     context 'with an unnamed lock' do

spec/lib/rmt/scc_spec.rb

@@ -238,7 +238,7 @@
         described_class.new.sync
       end
 
-      it 'removes existing predecessor associations' do
+      it 'removes existing predecessor associations', :skip_sqlite do
         expect { ProductPredecessorAssociation.find(existing_association.id) }.to raise_error(ActiveRecord::RecordNotFound)
       end
     end

spec/models/repository_spec.rb

@@ -146,7 +146,7 @@
       expect(friendly_id).to eq('my-repo-100000')
     end
 
-    it 'appends with unicode within the chain' do
+    it 'appends with unicode within the chain', :skip_sqlite do
       create(:repository, friendly_id: 'my-repo')
       create(:repository, friendly_id: 'my-repö-1')
       expect(friendly_id).to eq('my-repo-2')
@@ -165,13 +165,13 @@
         expect(friendly_id).to eq('dümmy-repö')
       end
 
-      it 'appends with unicode within the chain' do
+      it 'appends with unicode within the chain', :skip_sqlite do
         create(:repository, friendly_id: 'dummy-repo')
         create(:repository, friendly_id: 'dümmy-repö-1')
         expect(friendly_id).to eq('dümmy-repö-2')
       end
 
-      it 'correctly appends' do
+      it 'correctly appends', :skip_sqlite do
         create(:repository, friendly_id: 'dummy-repo')
         create(:repository, friendly_id: 'dummy-repo-1')
         expect(friendly_id).to eq('dümmy-repö-2')

spec/rails_helper.rb

@@ -58,6 +58,12 @@
   config.filter_rails_from_backtrace!
   # arbitrary gems may also be filtered via:
   # config.filter_gems_from_backtrace("gem name")
+
+  # Skipping some tests when running with (experimental) sqlite backend.
+  # Some tests / code parts are using specific mysql behavior
+  if ActiveRecord::Base.connection.adapter_name == 'SQLite'
+    config.filter_run_excluding skip_sqlite: true
+  end
 end
 
 Shoulda::Matchers.configure do |config|

spec/services/repository_service_spec.rb

@@ -88,7 +88,7 @@
 
       it('is not custom') { expect(repository.custom?).to eq(true) }
 
-      context 'already existing repositories with changing URL' do
+      context 'already existing repositories with changing URL', :skip_sqlite do
         subject(:repository) do
           service.create_repository!(product, url, attributes, custom: custom).reload
           url = 'https://foo.bar.com/bar/foo'