Updates required from testing in public cloud environment #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixsch
force-pushed
the
show-migration-warning
branch
from
ccb0fed to
3a9fa7a
Compare
digitaltom
reviewed
Dec 6, 2023
digitaltom
reviewed
Dec 6, 2023
felixsch
force-pushed
the
show-migration-warning
branch
from
f359b60 to
dc41c73
Compare
|
Well Done! Your tests are still passing. |
digitaltom
reviewed
Dec 8, 2023
engines/registration_sharing/app/controllers/registration_sharing/rmt_to_rmt_controller.rb
Show resolved
Hide resolved
digitaltom
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
The migration on the systems table might block the public cloud instances for an unknown amount of time, but I assume that is part of the tests (https://github.com/SUSE/scc-docs/pull/294/files).
|
Yep this is also part of the text. Luckily the migration takes place before RMT is started, meaning a planned downtime was always the case. That is also why we now print the message when updating the rpm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These are the changes which have been found while testing RMT in the public cloud:
instance_datato the correct place. This has been forgotten.How to test these changes:
instance_dataand migrate to the lastest database schema and checkinstance_datais still present