Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update package changes file #1053

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Update package changes file #1053

merged 2 commits into from
Dec 12, 2023

Conversation

ngetahun
Copy link
Contributor

@ngetahun ngetahun commented Dec 12, 2023 •
edited
Loading

Description

Updated rmt-server.changes in preparation for rmt release.

Change Type

Please select the correct option.

  • Bug Fix (a non-breaking change which fixes an issue)
  • New Feature (a non-breaking change which adds new functionality)
  • Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

  • I have verified that my code follows RMT's coding standards with rubocop.
  • I have reviewed my own code and believe that it's ready for an external review.
  • I have provided comments for any hard-to-understand code.
  • I have documented the MANUAL.md file with any changes to the user experience.
  • RMT's test coverage remains at 100%.
  • If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Other Notes

Please use this space to provide notes or thoughts to the team, such as tips on how to review/demo your changes.

@SUSE SUSE deleted a comment from suse-tests-pass Dec 12, 2023
@suse-tests-pass
Copy link
Collaborator

Well Done! Your tests are still passing.
https://ci.suse.de/job/scc-RMT-integration-tests/347753/console
If the given link has expired,you can force a Prophet rerun by just deleting this comment. (Merged a3476d6 into 3c6c504)

felixsch
felixsch approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@felixsch felixsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@ngetahun ngetahun merged commit 803d2b2 into master Dec 12, 2023
@ngetahun ngetahun deleted the update_package_changes branch December 12, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixsch felixsch felixsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ngetahun @suse-tests-pass @felixsch