Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3/x] Refactor suma mirroring #1059

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Conversation

ngetahun
Copy link
Contributor

@ngetahun ngetahun commented Jan 2, 2024

This PR is part of our code sprint: https://trello.com/c/hU27QHob/3134-rdeb-sprint-tracker

The whole changeset is:

[1/5] Prepare code sprint and implement repository type detection
[2/5] Add flat debian mirroring support to RMT
[3/5] Refactor suma mirroring
[4/5] Refactor repomd mirroring
[5/5] Fixes and cleanup
[6/6] Nested debian repository support

Implementation in this merge request:

  • Refactoring SUMA product tree mirroring into its own mirror class
  • Remove product tree mirroring from repomd and make tests green

DO NOT MERGE UNTIL COMPLETELY READY

How to test this pull request:

$ mv public/suma/product_tree.json public/suma/product_tree.old.json
$ bin/rmt-cli mirror
# expect: You should see a log line indicating downloading the product tree

$ diff public/suma/product_tree.json public_suma/product.tree.old.json
$ expect: It should if at all show a new product added but otherwise the same file

Thanks for reviewing this pull request!

If you have any question please do not hesitate to approach me! 🚀

@ngetahun ngetahun changed the base branch from master to refactor_mirror_action January 2, 2024 14:17
@ngetahun ngetahun changed the title RDEB: Refactor suma mirroring 3/x Refactor suma mirroring Jan 2, 2024
@felixsch felixsch changed the title 3/x Refactor suma mirroring [3/x] Refactor suma mirroring Jan 3, 2024
@SUSE SUSE deleted a comment from suse-tests-pass Jan 3, 2024
@SUSE SUSE deleted a comment from suse-tests-pass Jan 3, 2024
@SUSE SUSE deleted a comment from suse-tests-pass Jan 4, 2024
@SUSE SUSE deleted a comment from suse-tests-pass Jan 4, 2024
@felixsch felixsch added the On hold Issue being evaluated label Jan 9, 2024
@felixsch felixsch mentioned this pull request Jan 9, 2024
@SUSE SUSE deleted a comment from suse-tests-pass Jan 11, 2024
@lcaparroz lcaparroz force-pushed the refactor_mirror_action branch from 75d9d83 to 1efd7d9 Compare January 12, 2024 13:50
@SUSE SUSE deleted a comment from suse-tests-pass Jan 12, 2024
@lcaparroz lcaparroz force-pushed the refactor_suma_mirroring branch from 30afcb3 to df0236f Compare January 12, 2024 14:08
@lcaparroz lcaparroz force-pushed the refactor_suma_mirroring branch from df0236f to 41344af Compare January 12, 2024 18:04
@SUSE SUSE deleted a comment from suse-tests-pass Jan 12, 2024
@SUSE SUSE deleted a comment from suse-tests-pass Jan 24, 2024
@suse-tests-pass
Copy link
Collaborator

Well Done! Your tests are still passing.
https://ci.suse.de/job/scc-RMT-integration-tests/354752/console
If the given link has expired,you can force a Prophet rerun by just deleting this comment. (Merged 41344af into 024478b)

Base automatically changed from refactor_mirror_action to rmt_deb_codesprint January 29, 2024 13:02
@ngetahun ngetahun merged commit 3d0b3d3 into rmt_deb_codesprint Jan 29, 2024
1 check passed
@ngetahun ngetahun deleted the refactor_suma_mirroring branch January 29, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On hold Issue being evaluated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants