-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Collect uptime data in daily heartbeat from connect-ng #1069
Conversation
4f2a7e4
to
0acfa1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is no synchronization mechanism now, how exactly is this later extracted? Manually? Right now there is no synchronization to SCC implemented.
Another topic which is definitly needed I guess, is to come up with a solution which shares the uptimes with siblings instances in PubCloud.
Lets have a talk about this topics.
rescue ActiveRecord::RecordNotUnique | ||
logger.info(N_("Uptime information existing for system '%s'") % @system.id) | ||
end | ||
SystemUptime.where("online_at_day < '#{90.days.ago.to_date}'").delete_all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if this has impact on the RMT performance if it is called on every request. Did you look into this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss what the options are on wed morning meeting
spec/requests/api/connect/v3/systems/systems_controller_spec.rb
Outdated
Show resolved
Hide resolved
spec/requests/api/connect/v3/systems/systems_controller_spec.rb
Outdated
Show resolved
Hide resolved
spec/requests/api/connect/v3/systems/systems_controller_spec.rb
Outdated
Show resolved
Hide resolved
We have the rule of describing the at least a little bit in the PR description text what are you doing + having instructions how to test this changed behavior. Can you add these two missing items in the PR description? |
0dc6d6c
to
60bdec0
Compare
b9700ed
to
27ab9d8
Compare
Created new PR #1090 , so closing this |
Description
Uptime data is included in the data sent to SCC via RMT
https://jira.suse.com/browse/CSE-504
Fixes # (issue)
Change Type
Please select the correct option.
Checklist
Please check off each item if the requirement is met.
rubocop
.MANUAL.md
file with any changes to the user experience.package/obs/rmt-server.changes
.Other Notes
Please use this space to provide notes or thoughts to the team, such as tips on how to review/demo your changes.
How to test this PR
rails db:migrate
to create the system_uptimes tablebin/rails server -b 0.0.0.0
suseconnect --url <rmt_system_ip>
, it should populate the system_uptimes table with the entries from /etc/zypp/suse-uptime.logs on client system