Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add service credential url paramter if not necessary #1076

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

felixsch
Copy link
Contributor

In normal RMT environments, zypper services do not need a ?credentials URL parameter since the repository path is not authenticated.
So do not add it and allow yum to work with RMT for SLL7

part of: https://trello.com/c/BSMxlGDN/3166-help-liberty-team-get-suseconnect-working-on-liberty-7

How to review this pull request:

$ cd <rmt>
$ git checkout no-credentials-in-service-url
$ rails server

# another terminal
$ docker run --rm -it --network=host registry.suse.com/suse/sle15:15.4
> zypper in -y suseconnect-ng curl tidy
> SUSEConnect --url http://localhost:4224
> cat /etc/zypp/credentials.d/SCCcredentials
> curl -u <username:password> http://localhost:4224/services/2292 | tidy -xml -iq 
# expect: There is no `?credentials=XXX` in the repo.url

If you have any questions, please do not hesitate to reach out to me! 🚀

Thank you!

@felixsch felixsch force-pushed the no-credentials-in-service-url branch from 1bb8786 to 83f1540 Compare January 25, 2024 17:04
@felixsch
Copy link
Contributor Author

@jesusbv is looking into if it is possible to remove ?credentials= from the zypper_auth engine. Thank you

@ngetahun ngetahun self-requested a review January 26, 2024 08:58
@ngetahun
Copy link
Contributor

Pubcloud tests seem to be broken

@jesusbv
Copy link
Collaborator

jesusbv commented Jan 29, 2024

@jesusbv is looking into if it is possible to remove ?credentials= from the zypper_auth engine. Thank you

@felixsch I have checekd and we do need the credentials

In normal RMT environments, zypper services do not need a ?credentials
URL parameter since the repository path is not authenticated.

So do not add it and allow yum to work with RMT for SLL7
@felixsch felixsch force-pushed the no-credentials-in-service-url branch from 83f1540 to 3b28555 Compare January 29, 2024 13:56
@SUSE SUSE deleted a comment from suse-tests-pass Jan 29, 2024
Copy link
Contributor

@ngetahun ngetahun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested with given demo instructions

@suse-tests-pass
Copy link
Collaborator

Well Done! Your tests are still passing.
https://ci.suse.de/job/scc-RMT-integration-tests/355609/console
If the given link has expired,you can force a Prophet rerun by just deleting this comment. (Merged 3b28555 into 024478b)

@felixsch felixsch merged commit 36d721c into master Jan 29, 2024
3 checks passed
@felixsch felixsch deleted the no-credentials-in-service-url branch January 29, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants