Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liberty registration script support for sll7 clients #1095

Merged
merged 9 commits into from
Mar 5, 2024

Conversation

zpetrova
Copy link
Collaborator

@zpetrova zpetrova commented Feb 20, 2024

Description

Please describe your change and provide as much context as possible.

Fix for SUSE Liberty registration script to allow RHEL7/SLL7/CentOS7 clients to register to RMT servers

Fixes # (issue)

Change Type

Please select the correct option.

  • Bug Fix (a non-breaking change which fixes an issue)
  • New Feature (a non-breaking change which adds new functionality)
  • Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

  • I have verified that my code follows RMT's coding standards with rubocop.
  • I have reviewed my own code and believe that it's ready for an external review.
  • I have provided comments for any hard-to-understand code.
  • I have documented the MANUAL.md file with any changes to the user experience.
  • RMT's test coverage remains at 100%.
  • If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Other Notes

Please use this space to provide notes or thoughts to the team, such as tips on how to review/demo your changes.

We've tested the script on SLL,RHEL and CentOS version 7 and SLL, RHEL version 8,9

@digitaltom
Copy link
Member

digitaltom commented Feb 20, 2024

@zpetrova @plorinc does this supersede #1075? (that one seems to include some extra scripts)
FYI: I've added both of you as collaborators, so you can submit pull requests from branches and don't need to fork. This will enable the RMT feature tests to run on your pull requests.

@digitaltom
Copy link
Member

Could this get reviewed by @plorinc? We're lacking the infrastructure/setup for this.

@digitaltom digitaltom requested a review from plorinc February 21, 2024 13:05
@zpetrova
Copy link
Collaborator Author

Hi Thomas, if I look correctly #1075 adds three files (register.sh,rmt-client-setup-res7, rmt-client-setup7), rmt-client-setup-res supersede them. Lörinc already removed them.

@plorinc
Copy link
Collaborator

plorinc commented Feb 22, 2024

@digitaltom This supersedes #1075, the latter can be deleted.

Copy link
Collaborator

@plorinc plorinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

fi

echo "Disabling all repositories"
$YUM_CONFIG_MGR --disable \*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This produces a lot of output. Can this be piped to /dev/null or is the output required?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I redirected output of
$YUM_CONFIG_MGR --disable *
and
$YUM_CONFIG_MGR --enable suse.
to /dev/null
error output is not redirected.
see last two commits

$YUM_CONFIG_MGR --add-repo ${REGURL}/repo/SUSE/Updates/${SLL_name}/${SLL_version}/x86_64/update
$YUM_CONFIG_MGR --enable *suse.*

$YUM install SUSEConnect librepo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUSEConnect is not the package name but the executable. I'm not sure if yum supports Provides(..) rpm constructions. Please double check this and make sure to install the go version. The golang version is called suseconnect-ng. Check https://build.opensuse.org/project/show/home:lpato:sll7

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this install also the sll-release package or at least make sure that /etc/product.d/baseproduct is populated correctly, since this is required to run SUSEConnect -r later on.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the fix to this pull request (at least I hope I did it correctly).

Copy link
Contributor

@ngetahun ngetahun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zpetrova zpetrova merged commit 8626219 into SUSE:master Mar 5, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants