-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Liberty registration script support for sll7 clients #1095
Conversation
Could this get reviewed by @plorinc? We're lacking the infrastructure/setup for this. |
Hi Thomas, if I look correctly #1075 adds three files (register.sh,rmt-client-setup-res7, rmt-client-setup7), rmt-client-setup-res supersede them. Lörinc already removed them. |
@digitaltom This supersedes #1075, the latter can be deleted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
public/tools/rmt-client-setup-res
Outdated
fi | ||
|
||
echo "Disabling all repositories" | ||
$YUM_CONFIG_MGR --disable \* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This produces a lot of output. Can this be piped to /dev/null
or is the output required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I redirected output of
$YUM_CONFIG_MGR --disable *
and
$YUM_CONFIG_MGR --enable suse.
to /dev/null
error output is not redirected.
see last two commits
public/tools/rmt-client-setup-res
Outdated
$YUM_CONFIG_MGR --add-repo ${REGURL}/repo/SUSE/Updates/${SLL_name}/${SLL_version}/x86_64/update | ||
$YUM_CONFIG_MGR --enable *suse.* | ||
|
||
$YUM install SUSEConnect librepo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SUSEConnect
is not the package name but the executable. I'm not sure if yum
supports Provides(..)
rpm constructions. Please double check this and make sure to install the go version. The golang version is called suseconnect-ng
. Check https://build.opensuse.org/project/show/home:lpato:sll7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this install also the sll-release package or at least make sure that /etc/product.d/baseproduct
is populated correctly, since this is required to run SUSEConnect -r
later on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added the fix to this pull request (at least I hope I did it correctly).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Please describe your change and provide as much context as possible.
Fix for SUSE Liberty registration script to allow RHEL7/SLL7/CentOS7 clients to register to RMT servers
Fixes # (issue)
Change Type
Please select the correct option.
Checklist
Please check off each item if the requirement is met.
rubocop
.MANUAL.md
file with any changes to the user experience.package/obs/rmt-server.changes
.Other Notes
Please use this space to provide notes or thoughts to the team, such as tips on how to review/demo your changes.
We've tested the script on SLL,RHEL and CentOS version 7 and SLL, RHEL version 8,9