[#702] Improve mirroring summary #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adnilson
changed the title
Adnilson
changed the title
Adnilson
force-pushed
the
get_702_working_after_debian_refactor
branch
from
e994014 to
062d8a1
Compare
ngetahun
approved these changes
Apr 18, 2024
Adnilson
force-pushed
the
get_702_working_after_debian_refactor
branch
from
71e0615 to
be401e6
Compare
Adnilson
force-pushed
the
get_702_working_after_debian_refactor
branch
from
be401e6 to
df5fd7b
Compare
How should I update |
Just merged master and updated the release to version 2.17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR was created to make easier the implementation of the previous one as there were many conflicts by merging the debian changes that refactored the classes used by the implementation of this feature.
These are the changes I did on my technical interview to improve the summary of the mirroring process.
Fixes #702
Other Notes
Maybe we can update some rubocop rules
Regarding
spec/lib/rmt/cli/mirror_spec.rb:RSpec/ExpectOutput: Use expect { ... }.to output(...).to_stdout instead of mutating $stdout.I was unable to test well the summary output with the
outputhelper, so I decided to use the$stdoutwhich makes our test more robust.RSpec/MultipleExpectationsandRSpec/ExampleLengthwere ignored because of the changes belonging to the summary output which have more information.RSpec/ClassLengthin this case there 3 more lines than the limit which is 177. Is there a reason for this number?I prefer deep modules (with a simple interface) than shallow modules (with a complex interface) as I learned from: A Philosophy of Software Design by John Ousterhout.