Raise an exception for unknown CSPs #1207
Conversation
| unless INSTANCE_ID_KEYS.key?(id_key) | ||
| error_message = 'Unknown cloud provider' | ||
| Rails.logger.error error_message | ||
| raise ActionController::TranslatedError.new(error_message) |
There was a problem hiding this comment.
Why? I am unaware of any conversation at the business level where a decision was made that 3rd party CSPs that run their own update infrastructure are not allowed to offer BYOS pass through.
There was a problem hiding this comment.
if the CSP is unknown we would not have a valid value for system_token
do we not care about that ?
There was a problem hiding this comment.
I do not understand what the system_token has to do with this change. Nor what system_token has to do with now breaking functionality for 3rd party CSPs that previously probably worked when disable_system_tokens: true is set in the rmt.conf file.
There was a problem hiding this comment.
we are setting the system_token for BYOS systems and we use system_token to get the system
The method get_instance_id is the method that sets that value
Description
Instead of saving
nilor empty value on the DB forsystem_tokenfield, raise an exception if the CSP value from the metadata is unknownHow to test
Create a system with an unknown CSP, request should fail
Change Type
Please select the correct option.
Checklist
Please check off each item if the requirement is met.
MANUAL.mdfile with any changes to the user experience.package/obs/rmt-server.changes.Review
Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.