-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update system from hybrid to payg if no more non free products active #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deactivating a product on a hybrid system, if there are no more non free product active for that system on SCC, that system is no longer hybrid but payg and should get updated on the db
jesusbv
commented
Aug 27, 2024
rjschwei
approved these changes
Aug 27, 2024
digitaltom
reviewed
Aug 27, 2024
digitaltom
reviewed
Aug 27, 2024
Co-authored-by: Thomas Schmidt <[email protected]>
digitaltom
reviewed
Aug 28, 2024
Remove one line method and move the check to the method call
Move the exception handling to SccProxy's deactive_product_scc method Rename method for accuracy
If a hybrid system deactivates a product from SCC and has no more products on SCC, the system becomes PAYG and, as such, it should be deregister from SCC
digitaltom
reviewed
Aug 28, 2024
digitaltom
reviewed
Aug 28, 2024
digitaltom
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When deactivating a product on a hybrid system, if there are no more non free product active for that system on SCC, that system is no longer hybrid but payg and should get updated on the db
How to test
registercloudguest -r FOO
)SUSEConnect -l
and see LTSS being activeSUSEConnect -d -p LTSS
)payg
/ 1 in the db, in the RMT server, access the db, and runThe value for that field should be 1
Change Type
Please select the correct option.
Checklist
Please check off each item if the requirement is met.
MANUAL.md
file with any changes to the user experience.package/obs/rmt-server.changes
.Review
Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.