Make SccProxy method responsible for handling the SCC request response #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling SccProxy scc_activate_product method, the response should be handled in that method as well This helps reducing duplication and better responsibility separation Also, new method to announce hybrid system to SCC Update tests to reflect the changes
jesusbv
force-pushed
the
sccproxy-responsible-scc-request
branch
from
71729d5 to
d4be4b4
Compare
digitaltom
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When calling SccProxy scc_activate_product method, the response should be handled in that method as well
This helps reducing duplication and better responsibility separation
Also, new method to announce hybrid system to SCC
Update tests to reflect the changes
How to test
Activate a product from RMT to SCC , it should work as before
Change Type
Please select the correct option.
Checklist
Please check off each item if the requirement is met.
MANUAL.mdfile with any changes to the user experience.package/obs/rmt-server.changes.Review
Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.