Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update timer randomized delay #1242

Merged
merged 6 commits into from
Nov 12, 2024
Merged

Update timer randomized delay #1242

merged 6 commits into from
Nov 12, 2024

Conversation

ngetahun
Copy link
Contributor

@ngetahun ngetahun commented Oct 30, 2024 •
edited
Loading

Description

  • Related Issue / Ticket / Trello card:

How to test

Change Type

Please select the correct option.

  • Bug Fix (a non-breaking change which fixes an issue)
  • New Feature (a non-breaking change which adds new functionality)
  • Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

  • I have reviewed my own code and believe that it's ready for an external review.
  • I have provided comments for any hard-to-understand code.
  • I have documented the MANUAL.md file with any changes to the user experience.
  • If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Review

Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.

felixsch
felixsch previously approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@felixsch felixsch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@ngetahun ngetahun changed the title Update rmt 2.20 changelog entry Set timers as ghost Oct 30, 2024
@ngetahun ngetahun requested a review from felixsch October 30, 2024 12:07
@ngetahun ngetahun marked this pull request as draft October 30, 2024 12:08
@ngetahun ngetahun dismissed felixsch’s stale review November 11, 2024 08:26

The PR scope has changed which deems another review necessary.

@ngetahun ngetahun changed the title Set timers as ghost Update timer randomized delay Nov 11, 2024
@ngetahun ngetahun marked this pull request as ready for review November 11, 2024 10:54
@ngetahun
Copy link
Contributor Author

[REPCT] RMT packaging: make sync/mirror timer changes survive upgrade

felixsch
felixsch approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@felixsch felixsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@ngetahun ngetahun merged commit d0e7c01 into master Nov 12, 2024
3 checks passed
@ngetahun ngetahun deleted the update_rmt_2_20_changelog branch November 12, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesusbv jesusbv jesusbv left review comments

@digitaltom digitaltom digitaltom left review comments

@felixsch felixsch felixsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ngetahun @digitaltom @jesusbv @felixsch