-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor SUSE repo cleanup and local path generation logic supporting Akamai CDN #1257
Conversation
Do we need to somehow handle the installer-updates.suse.com domain (which will transition to dl-public.suse.com)? |
There's nothing specific about installer-updates.suse.com in RMT, should be good. |
The following are the different kind of repos that exists in scc.suse.com.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changelog entry, stating that RMT is enabled to handle the new dl.suse.com CDN domain.
Description
Refined
make_local_path
to handle URLs from both SUSE domains (https://updates.suse.com%
andhttps://dl.suse.com%
)/repo
in the path, such ashttps://updates.suse.com/repo/$RCE/SLES10-SP4-LTSS-Updates/sles-10-x86_64/
in SCC. When synced and mirrored, these URLs would lead to incorrect directory paths locally.https://updates.suse.com/repo/$RCE/...
would be updated tohttps://dl.suse.com/repo/$RCE/...
. Without this fix, mirrored repositories would incorrectly create local paths like/repo/repo/...
./repo
prefix, ensuring the correct local path structure.Updated
remove_suse_repos_without_tokens!
to delete repositories with URLs from both the old (https://updates.suse.com%
) and new (https://dl.suse.com%
) CDN domains whenauth_token
isnil
.https://updates.suse.com%
were cleared.https://dl.suse.com%
are now also deleted when lacking an authentication token.https://trello.com/c/YFbHJEkq/3669-edgxit-test-migration-to-new-cdn-domain-auth-token-with-rmt
How to test
Review
Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.