Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rmt cleanup old metadata #1261

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Rmt cleanup old metadata #1261

merged 5 commits into from
Dec 18, 2024

Conversation

paragjain0910
Copy link
Contributor

Description

This task is for cleaning up old metadata files after repository updates in the CDN.

https://trello.com/c/SznwZfr3/3662-l3-regression-rmt-doesnt-clean-up-metadata

How to test ( locally )

1) Enable a repository using the command:  ` rmt-cli repos enable <repo-id>`
2) Run the mirror command:  ` rmt-cli mirror`
3) Rename any metadata file in the repodata directory (e.g., rmt/public/repo/SUSE/Products/SLE-Product-SLES/15-SP6/ppc64le/product/repodata).
4) Run the mirror command again: `   rmt-cli mirror`

Check whether it will remove the renamed metadata file from the repodata directory and download the updated one from the CDN.

Change Type

Please select the correct option.

  • [* ] Bug Fix (a non-breaking change which fixes an issue)
  • New Feature (a non-breaking change which adds new functionality)
  • Documentation Update (a change which only updates documentation)

lib/rmt/mirror/base.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@felixsch felixsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

How I reviewed this pull request:

  • Checked for changes I want to suggest
  • Ran the branch and mirrored repository:
    • Renamed a file to simulate updated metadata
    • Checked the files get cleaned
    • Remirrored and checked again

As always, if you think I missed something I should test, please let me know!🚀

@paragjain0910 paragjain0910 merged commit b0db3be into master Dec 18, 2024
3 checks passed
@paragjain0910 paragjain0910 deleted the rmt-cleanup-old-metadata branch December 18, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants