-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround s390 clients delete #1559
Conversation
// WORKAROUND: Remove s390 clients manually until https://github.com/SUSE/spacewalk/issues/26502 is fixed. | ||
sh """ | ||
set +x | ||
source ~/.credentials |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be caution here, as we have a set +x on the line above, it might be printing credentials visibile from the Jenkins web, that we might not want to show.
# Iterate through each userid and delete the s390 clients | ||
for USERID in $USERIDS; do | ||
echo "Deleting client with userid: $USERID" | ||
/usr/local/bin/delete_s390_guest "$USERID" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That binary is already part of our IaC in the infrastructure repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but I can add it, as well as its friend list_s390_clients.
It will make sense on the workers even when the workaround is gone. As a convenience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Eric, if it's a dependency for our pipeline, yes we need it automated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the workaround is removed (hopefully before it snows in hell...) it won't be a dependency anymore for our pipelines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The deletion of s390 clients using terraform destroy is failing due to the issue described in #26502." --> Do we have a 26502, or is it a typo ? There's no link
Context
The deletion of s390 clients using terraform destroy is failing due to the issue described in #26502. This problem is currently blocking the BV cleanup pipeline and the ability to clean up the BV environment using Terraform.
Since a long-term solution is not expected soon, this PR introduces a temporary workaround to address the issue.
What does this PR do?
Bash Script
Cleanup Pipeline