Add telemetry-admin placeholder #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The telemetry-admin service will be used to perform management operations on the databases managed by the telemetry-server service. For now those management operations are still being defined so this patch set is just adding support for building and running an admin service that responds to healthchecks. Note also that support has been added for API requests to report their success status at debug rather than info level, with the healthcheck request handlers being updated to make use of this so that the frequent healthcheck operations don't cause too much chatter in the service logs. The Dockerfile has been updated to support building both the server and admin services. The docker/compose.yaml has been updated to start the admin service as a dependency of the main telemetry service. Updated README.md to reflect addition of telemetry-admin service to the docker compose deployment. NOTE: The helm charts will be updated to support deploying the admin service is a followup PR.
gbuenodevsuse
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The telemetry-admin service will be used to perform management operations on the databases managed by the telemetry-server service.
For now those management operations are still being defined so this patch set is just adding support for building and running an admin service that responds to healthchecks.
Note also that support has been added for API requests to report their success status at debug rather than info level, with the healthcheck request handlers being updated to make use of this so that the frequent healthcheck operations don't cause too much chatter in the service logs.
The Dockerfile has been updated to support building both the server and admin services.
The docker/compose.yaml has been updated to start the admin service as a dependency of the main telemetry service.
Updated README.md to reflect addition of telemetry-admin service to the docker compose deployment.
NOTE: The helm charts will be updated to support deploying the admin service is a followup PR.