refactor: 코드리뷰 반영

- setter 삭제 #170
SW-CSS · Sep 11, 2024 · 9428736 · 9428736
1 parent e62b873
commit 9428736
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/backend/src/main/java/sw_css/admin/auth/application/AdminAuthCommandService.java b/backend/src/main/java/sw_css/admin/auth/application/AdminAuthCommandService.java
@@ -107,10 +107,9 @@ private Workbook generateWorkbook(final MultipartFile file, String extension) {
     private void saveFaculty(final String email, final String name, final String password) {
         Member member = new Member(email, name, password, "01000000000", false);
 
-        final long memberId = memberRepository.save(member).getId();
-        member.setId(memberId);
+        final Member savedMember = memberRepository.save(member);
 
-        FacultyMember facultyMember = new FacultyMember(null, member);
+        FacultyMember facultyMember = new FacultyMember(null, savedMember);
         facultyMemberRepository.save(facultyMember);
     }
 

diff --git a/backend/src/main/java/sw_css/member/domain/Member.java b/backend/src/main/java/sw_css/member/domain/Member.java
@@ -21,7 +21,6 @@
 @SQLRestriction("is_deleted = false")
 public class Member extends BaseEntity {
     @Id
-    @Setter(AccessLevel.PUBLIC)
     @GeneratedValue(strategy = GenerationType.IDENTITY)
     private Long id;
 

diff --git a/backend/src/main/java/sw_css/member/domain/StudentMember.java b/backend/src/main/java/sw_css/member/domain/StudentMember.java
@@ -12,12 +12,10 @@
 import lombok.AllArgsConstructor;
 import lombok.Getter;
 import lombok.NoArgsConstructor;
-import lombok.Setter;
 import sw_css.base.BaseEntity;
 import sw_css.major.domain.Major;
 
 @Entity
-@Setter(AccessLevel.PUBLIC)
 @Getter
 @AllArgsConstructor
 @NoArgsConstructor(access = AccessLevel.PROTECTED)