Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Missing Improved Force Cloak to Expertise. #379

Closed
wants to merge 1 commit into from

Conversation

TalisaKnight
Copy link
Contributor

No description provided.

@AconiteX
Copy link
Member

AconiteX commented Jul 4, 2024

This is wrong for 3 reasons: 1\ you added this entry as a duplicate instead of modifying the existing row with this entry; 2\ you added expertise_fs_general_force_cloak_1 to the column PREREQ_LEVEL, which is especially confusing given this wouldn't compile since the column is an integer type, and context clues of every other row in the table should indicate this should be left blank; and 3\ PRs to base game files need to include a note that they are proper according to the final day of NGE either by reference to patch note or the original client

@AconiteX AconiteX closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants