Merge pull request #332 from SWM-NM/feat/#330

[ADD] MemberController 관련 테스트 코드 작성
SWM-Morandi · Sep 21, 2023 · e2e6707 · e2e6707
2 parents eefaed1 + c3a2d80
commit e2e6707
Show file tree

Hide file tree

Showing 5 changed files with 129 additions and 7 deletions.
diff --git a/src/main/java/swm_nm/morandi/domain/member/service/MemberEditService.java b/src/main/java/swm_nm/morandi/domain/member/service/MemberEditService.java
@@ -1,5 +1,4 @@
 package swm_nm.morandi.domain.member.service;
-
 import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.stereotype.Service;
@@ -8,7 +7,6 @@
 import swm_nm.morandi.global.exception.MorandiException;
 import swm_nm.morandi.global.exception.errorcode.MemberErrorCode;
 import swm_nm.morandi.global.utils.SecurityUtils;
-
 import javax.transaction.Transactional;
 
 @Service
@@ -18,10 +16,10 @@ public class MemberEditService {
 
     private final MemberRepository memberRepository;
     @Transactional
-    public void editProfile(String nickname, String bojId) {
+    public void editProfile(String introduceInfo, String bojId) {
         Long memberId = SecurityUtils.getCurrentMemberId();
         Member member = memberRepository.findById(memberId).orElseThrow(
                 () -> new MorandiException(MemberErrorCode.MEMBER_NOT_FOUND));
-        member.editProfile(nickname, bojId);
+        member.editProfile(introduceInfo, bojId);
     }
 }
diff --git a/src/main/java/swm_nm/morandi/domain/member/service/MemberInitService.java b/src/main/java/swm_nm/morandi/domain/member/service/MemberInitService.java
@@ -10,18 +10,20 @@
 import swm_nm.morandi.global.exception.errorcode.AuthErrorCode;
 import swm_nm.morandi.global.utils.SecurityUtils;
 
+import javax.transaction.Transactional;
+
 @Service
 @RequiredArgsConstructor
 @Slf4j
 public class MemberInitService {
 
     private final MemberRepository memberRepository;
 
+    @Transactional
     public RegisterInfoDto memberInitialize(RegisterInfoDto registerInfoDto) {
-        Long userId = SecurityUtils.getCurrentMemberId();
-        Member member = memberRepository.findById(userId).orElseThrow(()-> new MorandiException(AuthErrorCode.MEMBER_NOT_FOUND));
+        Long memberId = SecurityUtils.getCurrentMemberId();
+        Member member = memberRepository.findById(memberId).orElseThrow(()-> new MorandiException(AuthErrorCode.MEMBER_NOT_FOUND));
         member.setBojId(registerInfoDto.getBojId());
-        memberRepository.save(member);
         return registerInfoDto;
     }
 }
diff --git a/src/test/java/swm_nm/morandi/domain/member/service/MemberEditServiceTest.java b/src/test/java/swm_nm/morandi/domain/member/service/MemberEditServiceTest.java
@@ -0,0 +1,45 @@
+package swm_nm.morandi.domain.member.service;
+
+import org.assertj.core.api.Assertions;
+import org.junit.jupiter.api.Test;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.test.context.SpringBootTest;
+import org.springframework.security.test.context.support.WithMockUser;
+import org.springframework.transaction.annotation.Transactional;
+import swm_nm.morandi.domain.member.dto.MemberInfoDto;
+import swm_nm.morandi.domain.member.entity.Member;
+import swm_nm.morandi.domain.member.repository.MemberRepository;
+
+import java.util.Optional;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.jupiter.api.Assertions.*;
+
+@SpringBootTest
+@WithMockUser(username = "1",  roles = "USER")
+class MemberEditServiceTest {
+
+    @Autowired
+    private MemberEditService memberEditService;
+
+    @Autowired
+    private MemberRepository memberRepository;
+    @Test
+    @Transactional
+    void editProfile() {
+        // given
+        MemberInfoDto memberInfoDto = new MemberInfoDto();
+        memberInfoDto.setIntroduceInfo("hello world");
+        memberInfoDto.setBojId("aj4941");
+
+        // when
+        memberEditService.editProfile(memberInfoDto.getIntroduceInfo(), memberInfoDto.getBojId());
+
+        // then
+        Optional<Member> result = memberRepository.findById(1L);
+        Member findMember = result.get();
+
+        assertThat(findMember.getIntroduceInfo()).isEqualTo("hello world");
+        assertThat(findMember.getBojId()).isEqualTo("aj4941");
+    }
+}
diff --git a/src/test/java/swm_nm/morandi/domain/member/service/MemberInfoServiceTest.java b/src/test/java/swm_nm/morandi/domain/member/service/MemberInfoServiceTest.java
@@ -0,0 +1,38 @@
+package swm_nm.morandi.domain.member.service;
+import org.assertj.core.api.Assertions;
+import org.junit.jupiter.api.Test;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.test.context.SpringBootTest;
+import org.springframework.security.test.context.support.WithMockUser;
+import org.springframework.transaction.annotation.Transactional;
+import swm_nm.morandi.domain.member.dto.MemberInfoDto;
+import swm_nm.morandi.domain.member.entity.Member;
+import swm_nm.morandi.domain.member.repository.MemberRepository;
+
+import java.util.Optional;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+@SpringBootTest
+@WithMockUser(username = "1", roles = "USER")
+class MemberInfoServiceTest {
+
+    @Autowired
+    private MemberInfoService memberInfoService;
+
+    @Autowired
+    private MemberRepository memberRepository;
+    @Test
+    @Transactional
+    void getMemberInfo() {
+        // given
+        Optional<Member> result = memberRepository.findById(1L);
+        Member member = result.get();
+
+        // when
+        MemberInfoDto memberInfo = memberInfoService.getMemberInfo();
+
+        // then
+        assertThat(memberInfo.getBojId()).isEqualTo(member.getBojId());
+    }
+}
diff --git a/src/test/java/swm_nm/morandi/domain/member/service/MemberInitServiceTest.java b/src/test/java/swm_nm/morandi/domain/member/service/MemberInitServiceTest.java
@@ -0,0 +1,39 @@
+package swm_nm.morandi.domain.member.service;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.test.context.SpringBootTest;
+import org.springframework.security.test.context.support.WithMockUser;
+import org.springframework.transaction.annotation.Transactional;
+import swm_nm.morandi.domain.member.dto.RegisterInfoDto;
+import swm_nm.morandi.domain.member.entity.Member;
+import swm_nm.morandi.domain.member.repository.MemberRepository;
+
+import java.util.List;
+import java.util.Optional;
+import static org.assertj.core.api.Assertions.assertThat;
+@SpringBootTest
+@WithMockUser(username = "1", roles = "USER")
+class MemberInitServiceTest {
+
+    @Autowired
+    private MemberRepository memberRepository;
+
+    @Autowired
+    private MemberInitService memberInitService;
+    @Test
+    void memberInitialize() {
+        // given
+        RegisterInfoDto registerInfoDto = RegisterInfoDto.builder()
+                .bojId("aj4941")
+                .build();
+
+        // when
+        memberInitService.memberInitialize(registerInfoDto);
+
+        // then
+        Optional<Member> result = memberRepository.findById(1L);
+        Member findMember = result.get();
+        assertThat(findMember.getBojId()).isEqualTo("aj4941");
+    }
+}