Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark the git repo as a safe directory #33

Merged
merged 13 commits into from
Aug 16, 2024
Merged

Mark the git repo as a safe directory #33

merged 13 commits into from
Aug 16, 2024

Conversation

tschaffter
Copy link
Contributor

@tschaffter tschaffter commented Aug 14, 2024 •
edited
Loading

Changelogs

  • Mark the directory open in the dev container as safe for git (required to run pre-commit)
  • Move all the post create command steps to tools/setup.sh
  • Add pre-commit to the dev dependencies

References

@tschaffter tschaffter marked this pull request as ready for review August 14, 2024 17:43
zaro0508
zaro0508 approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@zaro0508 zaro0508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just had another suggestion to streamline the dev env setup.

.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
@tschaffter tschaffter requested a review from zaro0508 August 14, 2024 22:18
zaro0508
zaro0508 requested changes Aug 15, 2024
View reviewed changes
tools/setup.sh Outdated Show resolved Hide resolved
.devcontainer/devcontainer.json Show resolved Hide resolved
requirements-dev.txt Outdated Show resolved Hide resolved
@tschaffter tschaffter requested a review from a team as a code owner August 15, 2024 20:20
@tschaffter tschaffter requested a review from zaro0508 August 15, 2024 20:29
zaro0508
zaro0508 requested changes Aug 15, 2024
View reviewed changes
requirements-dev.txt Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@tschaffter tschaffter requested a review from zaro0508 August 15, 2024 22:30
zaro0508
zaro0508 approved these changes Aug 16, 2024
View reviewed changes
README.md Show resolved Hide resolved
@zaro0508 zaro0508 merged commit fe652c9 into Sage-Bionetworks-IT:dev Aug 16, 2024
4 checks passed
@tschaffter tschaffter deleted the mark-repo-as-safe-directory branch October 14, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaro0508 zaro0508 zaro0508 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tschaffter @zaro0508