Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IT-3512] Refactor and cleanup #41

Merged
merged 2 commits into from
Sep 13, 2024
Merged

[IT-3512] Refactor and cleanup #41

merged 2 commits into from
Sep 13, 2024

Conversation

zaro0508
Copy link
Contributor

@zaro0508 zaro0508 commented Sep 10, 2024 •
edited
Loading

  • remove docker folder because this repo doesn't use it
  • remove LoadBalancedHttpServiceStack because it's not used
  • Get namespace, subdomain and vpc cidr from config file instead of hard coding it in code.
  • Parameterize the https certificate ARN

@zaro0508
[IT-3512] Refactor and cleanup
5e9bfe7 
* remove docker folder because this repo doesn't use it
* remove LoadBalancedHttpServiceStack because it's not used
* Get namespace, subdomain and vpc cidr from config file instead of
  hard coding it in code.
@zaro0508 zaro0508 requested review from a team as code owners September 10, 2024 17:09
@zaro0508 zaro0508 requested a review from tschaffter September 10, 2024 17:10
@zaro0508 zaro0508 merged commit df70ef6 into Sage-Bionetworks-IT:dev Sep 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xschildw xschildw xschildw approved these changes

@tschaffter tschaffter Awaiting requested review from tschaffter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zaro0508 @xschildw