Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLFM-8102: Use Admin Access #1254

Merged
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions org-formation/650-identity-providers/_tasks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -882,11 +882,8 @@ GithubOidcNbConvertDeploy:
ProviderRoleName: !Sub ${resourcePrefix}-${appName}-nbconvert-deploy
MaxSessionDuration: 7200
ManagedPolicyArns:
- "arn:aws:iam::aws:policy/AmazonEC2ContainerRegistryFullAccess"
- "arn:aws:iam::aws:policy/AWSLambda_FullAccess"
- "arn:aws:iam::aws:policy/CloudWatchLogsFullAccess"
- "arn:aws:iam::aws:policy/IAMFullAccess"
- "arn:aws:iam::aws:policy/AWSCloudFormationFullAccess"
- "arn:aws:iam::aws:policy/AdministratorAccess"
Copy link
Contributor

@zaro0508 zaro0508 Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resource is now basically the same as the existing GithubOidcSageBionetworksSynapseDockerRegistry. Do you think it would make sense to consolidate these to a single generic GithubOidcSageBionetworksSynapse resource that gives access to multiple repos? The benefit is that when new repos pop up to deploy lambda or CDK they can just use the generic resource.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Renamed, added registry repo.

- "arn:aws:iam::aws:policy/AWSKeyManagementServicePowerUser"
TemplatingContext:
GitHubOrg: "Sage-Bionetworks"
Repositories:
Expand Down