IT-3860: Pass secure parameter to automation script #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on instances tagged appropriately
for more information, see https://pre-commit.ci
…ompatible with SSM Automation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
zaro0508
requested changes
Oct 16, 2024
| envVarName=envParamNamePair[0] | ||
| ssmParamName=envParamNamePair[1] | ||
| envVarValue = client.get_parameter(Name=ssmParamName, WithDecryption=True)['Parameter']['Value'] | ||
| keyValuePair=envVarName+":"+envVarValue |
There was a problem hiding this comment.
what if envVarValue returns None or empty? should we check for that?
There was a problem hiding this comment.
If so then the script will get a blank value for the given env var. That will only happen if someone enters an empty value in SSM Parameter Store.
There was a problem hiding this comment.
what if they forget to define the parameter in the AWS SSM? or they define it with an parameter name that doesn't match the one that's passed in to these templates?
There was a problem hiding this comment.
In that case line 196 will raise an exception, i.e., get_parameter will fail.
zaro0508
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While CloudFormation allows invoking SSM Parameter look up when passing parameters , Organization Formation fails with the error:
The fix is instead to simply pass the SSM Parameter name to the Automation script and update the Lambda to retrieve the secure parameter(s) to pass to the Automation Document.
This PR also updates the documentation to explain how to use the script.