Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IT-3421: Add vulnerability scanning to container build #3

Merged
merged 53 commits into from
Aug 13, 2024

Conversation

brucehoff
Copy link
Contributor

@brucehoff brucehoff commented Jul 31, 2024

  • Builds container and caches it as a '.tar' file
  • Passes the '.tar' file to Trivy for vulnerabilty checking
  • Vul'n findings appear under the GitHub "Security" tab
  • Only pushes container image to GHCR if vul'n scan passes
  • Pushes to multiple tags, including Major.minor.patch and Major.minor, allowing the update of Major.minor for security fixes
  • Provides the ability to suppress "false positive" findings
  • Adds a daily scan, to identify new vul'ns in existing image
  • Documents how vul'n scanning and versioning work in README
  • Updates the base image from RStudio 4.3 to 4.4 (to address identified vulnerabilities)

Note: We increase the 80 character limit to 200 in .yaml files because in trivy.yml we need to list files to skip, some of which have path lengths > 80 characters, and breaking them over multiple lines is unwieldy.

@brucehoff brucehoff requested a review from a team July 31, 2024 15:18
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Dockerfile Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.yamllint.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
.github/workflows/trivy.yml Show resolved Hide resolved
@brucehoff brucehoff requested a review from zaro0508 August 2, 2024 21:51
@brucehoff brucehoff requested a review from a team August 2, 2024 23:15
@brucehoff brucehoff requested a review from zaro0508 August 12, 2024 15:59
@brucehoff brucehoff merged commit 8f59162 into Sage-Bionetworks-IT:main Aug 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants