IT-3921: Fix periodic image scan and image rebuild #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two changes:
(1) Downloading the trivy-db from its default GitHub location fails because the site experiences too many downloads. The fix is to pull from an alternate location, hosted in AWS ECR;
(2) The logic to rebuild the image when the Trivy job fails didn't work. The evidence is here. The
ifcondition for theupdate-imagejob needs to start withalways() &&or, alternatively,!cancelled() &&. While logically addingTRUE &&should make no change, this is required for GitHub Workflows to work correctly, as discussed here.