Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IT-4004: Update dependencies; make build fail when package installations fail #9

Merged
merged 14 commits into from
Nov 13, 2024

Conversation

brucehoff
Copy link
Contributor

In IT-4004 we discovered that we were publishing a version of the notebook in which some of the included packages failed to install. This PR changes the build so that when a package fails to install the build will also fail. This PR also includes the updates to make the packages install (so the build passes).

@brucehoff brucehoff requested a review from xschildw November 13, 2024 23:17
Copy link

@xschildw xschildw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brucehoff brucehoff merged commit 2a20812 into Sage-Bionetworks-IT:main Nov 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants