-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ORCA-294] Fix tox
implementation in CI pipeline
#53
Merged
BWMac
merged 12 commits into
bwmac/ORCA-288/test_object_refactor
from
bwmac/ORCA-294/fix_tox
Dec 14, 2023
Merged
[ORCA-294] Fix tox
implementation in CI pipeline
#53
BWMac
merged 12 commits into
bwmac/ORCA-288/test_object_refactor
from
bwmac/ORCA-294/fix_tox
Dec 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## bwmac/ORCA-288/test_object_refactor #53 +/- ##
=======================================================================
Coverage ? 100.00%
=======================================================================
Files ? 24
Lines ? 1184
Branches ? 192
=======================================================================
Hits ? 1184
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
BWMac
changed the base branch from
main
to
bwmac/ORCA-288/test_object_refactor
December 13, 2023 17:19
BWMac
changed the title
[ORCA-294] Fix Tox
[ORCA-294] Fix Dec 13, 2023
tox
implementation in CI pipeline
thomasyu888
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Our CI pipeline is failing to test our code with the intended Python versions.
Solution:
Update
ci.yml
to use thetox-gh
GH Actions plugin.Notes:
tox
is no longer a required dependency of the repository because we are installingtox-gh
during our CI runs according to the recommended usage.tox
in their CI pipeline.Run tests
steps undertox:py
match those expected before approving as a sanity check.