Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ORCA-294] Fix tox implementation in CI pipeline #53

Merged
merged 12 commits into from
Dec 14, 2023

Conversation

BWMac
Copy link
Contributor

@BWMac BWMac commented Dec 13, 2023

Problem:

Our CI pipeline is failing to test our code with the intended Python versions.

Solution:

Update ci.yml to use the tox-gh GH Actions plugin.

Notes:

  • Once we were testing the Python versions we intended, it became clear that this codebase was not actually compatible with Python 3.8. I am changing the compatibility to 3.9-3.11 as a result. I do not expect this to impact any users.
  • tox is no longer a required dependency of the repository because we are installing tox-gh during our CI runs according to the recommended usage.
  • This PR will serve as a model for any other repositories we own that use tox in their CI pipeline.
  • A GH Action run with these changes can be viewed here.
    • Please verify that the versions listed in the logs for the Run tests steps under tox:py match those expected before approving as a sanity check.

Copy link

swarmia bot commented Dec 13, 2023

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (bwmac/ORCA-288/test_object_refactor@ebae79f). Click here to learn what that means.

Additional details and impacted files
@@                           Coverage Diff                           @@
##             bwmac/ORCA-288/test_object_refactor       #53   +/-   ##
=======================================================================
  Coverage                                       ?   100.00%           
=======================================================================
  Files                                          ?        24           
  Lines                                          ?      1184           
  Branches                                       ?       192           
=======================================================================
  Hits                                           ?      1184           
  Misses                                         ?         0           
  Partials                                       ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BWMac BWMac changed the base branch from main to bwmac/ORCA-288/test_object_refactor December 13, 2023 17:19
@BWMac BWMac changed the title [ORCA-294] Fix Tox [ORCA-294] Fix tox implementation in CI pipeline Dec 13, 2023
@BWMac BWMac marked this pull request as ready for review December 13, 2023 18:32
Copy link
Contributor

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM!

@BWMac BWMac merged commit 4867bc8 into bwmac/ORCA-288/test_object_refactor Dec 14, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants