Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin requests version #57

Merged
merged 9 commits into from
Jun 18, 2024
Merged

Pin requests version #57

merged 9 commits into from
Jun 18, 2024

Conversation

BWMac
Copy link
Contributor

@BWMac BWMac commented Jun 17, 2024

Problem:
There appears to have been a breaking change for docker-py introduced by requests v2.32.0. This change should prevent that from breaking our CI and development environments.

Solution:
Pin the requests version to <=2.31.

Notes:

  • I also added gh_token as an argument to the keepalive-workflow in the CI workflow. See this PR for the reasoning.
  • There was also an additional issue with the container version being used (deprecation) in the GrepDateTimeTest, I bumped it up to the latest published version in biocontainers.

@BWMac BWMac changed the title bump requests Pin requests version to >2.32 Jun 17, 2024
Copy link
Contributor

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM! I know this is in draft mode but thought i'd review

@BWMac BWMac changed the title Pin requests version to >2.32 Pin requests version Jun 17, 2024
Copy link

sonarcloud bot commented Jun 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@BWMac BWMac marked this pull request as ready for review June 18, 2024 19:38
@BWMac BWMac requested a review from a team as a code owner June 18, 2024 19:38
@BWMac BWMac merged commit dfc08ff into main Jun 18, 2024
11 checks passed
@BWMac BWMac deleted the bwmac/docker-py-bug branch June 18, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants