AG-1425 fix breaking unit tests

Sage-Bionetworks · May 9, 2024 · 9f19393 · 9f19393
1 parent 45ffc4c
commit 9f19393
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 18 deletions.
diff --git a/...app/features/genes/components/gene-comparison-tool/gene-comparison-tool.component.spec.ts b/...app/features/genes/components/gene-comparison-tool/gene-comparison-tool.component.spec.ts
@@ -112,6 +112,7 @@ describe('Component: GeneComparisonToolComponent', () => {
 
   it('should search', () => {
     component.initData([comparisonGeneMock1, comparisonGeneMock2]);
+    component.refresh();
     fixture.detectChanges();
 
     const input = element.querySelector(
@@ -180,7 +181,7 @@ describe('Component: GeneComparisonToolComponent', () => {
 
     el = element.querySelector('#pinned-genes-header') as HTMLElement;
 
-    expect(el.textContent).toBe('Pinned Genes (1/50)');
+    expect(el.textContent?.trim()).toBe('Pinned Genes (1/50)');
   });
 
   it('should pin/upin gene', () => {
@@ -191,11 +192,11 @@ describe('Component: GeneComparisonToolComponent', () => {
     fixture.detectChanges();
     expect(component.pinnedGenes.length).toEqual(0);
 
-    component.pinGene(comparisonGeneMock1, true);
+    component.onPinGeneClick(comparisonGeneMock1);
     fixture.detectChanges();
     expect(component.pinnedGenes.length).toEqual(1);
 
-    component.unpinGene(comparisonGeneMock1, true);
+    component.onUnPinGeneClick(comparisonGeneMock1, true);
     fixture.detectChanges();
     expect(component.pinnedGenes.length).toEqual(0);
   });
@@ -397,7 +398,7 @@ describe('Component: GeneComparisonToolComponent', () => {
       expect(
         element.querySelector(TOGGLE_CLASS)?.querySelector('input')?.checked
       ).toBeTrue();
-      expect(component.getUrlParam('significance')[0]).toEqual(
+      expect(component.getUrlParam('significance')).toEqual(
         threshold
       );
     };

diff --git a/src/app/features/genes/components/gene-comparison-tool/gene-comparison-tool.component.ts b/src/app/features/genes/components/gene-comparison-tool/gene-comparison-tool.component.ts
@@ -241,10 +241,6 @@ export class GeneComparisonToolComponent implements OnInit, AVI, OnDestroy {
     return property.split('.').reduce((o: any, i: any) => o[i], gene);
   }
 
-  getPreviousPins() {
-    return this.pinnedGenes;
-  }
-
   initData(genes: GCTGene[]) {
     // hide brain region columns initially
     this.brainRegionsColumns.forEach(c => c.visible = false);
@@ -656,21 +652,12 @@ export class GeneComparisonToolComponent implements OnInit, AVI, OnDestroy {
     this.lastPinnedSubCategory = this.subCategory;
   }
 
-  getPinCategories() {
-    const categories = this.getPinnedGenesCacheKey(this.category, this.subCategory);
-    return categories;
-  }
-
   getPinnedGenesCacheKey(category: string, subCategory?: string) {
     return (category + (subCategory ? '-' + subCategory : ''))
       .replace(/[^a-z0-9]/gi, '')
       .toLowerCase();
   }
 
-  getPinnedGenesCache() {
-    return this.pinnedGenesCache;
-  }
-
   setPinnedGenesCache(genes: GCTGene[]) {
     this.pinnedGenesCache = genes;
   }
@@ -966,7 +953,7 @@ export class GeneComparisonToolComponent implements OnInit, AVI, OnDestroy {
     }
 
     if (this.significanceThresholdActive) {
-      params['significance'] = [this.significanceThreshold];
+      params['significance'] = this.significanceThreshold;
     }
 
     this.urlParams = params;