[IT-3266] Move bastian host into private subnet #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We switch to using GH self hosted runner therefore the bastian hosts do not need to be accessible from the internet anymore. depends on Sage-Bionetworks/agora-data-manager#116
zaro0508
commented
Jan 8, 2024
| @@ -12,7 +12,7 @@ parameters: | |||
| # Name of an the environment either develop, staging or prod | |||
| Environment: "develop" | |||
| # Name of an existing VPC subnet to run the instance in | |||
| VpcSubnet: "PublicSubnet" | |||
| VpcSubnet: "PrivateSubnet" | |||
There was a problem hiding this comment.
Note: AWS will create a new EC2 instance on this change which means that the Github self-hosted runners (in agora-data-manger repo) will need to be manually re-configured.
xschildw
approved these changes
Jan 9, 2024
i would prefer to figure out a way to automate setting up of the bastian as a github self-hosted runner. i'm thinking it might be possible to bootstrap the self-hosted runner config and run scripts in the EC2 init. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We switch to using GH self hosted runner therefore the bastian hosts do not need to be accessible from the internet anymore.
depends on Sage-Bionetworks/agora-data-manager#116