Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETL-671] Update to use older node version on aws actions #124

Merged
merged 9 commits into from
Jul 10, 2024
Merged

[ETL-671] Update to use older node version on aws actions #124

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
896d1e5
test installing glibc 2.28 layer
rxu17 Jul 3, 2024
042e607
separate cmds
rxu17 Jul 3, 2024
e0f8f4d
use older node workaround
rxu17 Jul 6, 2024
2f491d6
try to isolate aws configure credentials outside of docker build
rxu17 Jul 7, 2024
f8548cb
try to separate out aws configure vs building docker
rxu17 Jul 8, 2024
5c2d736
add vars
rxu17 Jul 8, 2024
b21bb41
add back in unmasking
rxu17 Jul 8, 2024
b8d874a
fix credentials access
rxu17 Jul 9, 2024
7311bad
revert
rxu17 Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/upload-and-deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ env:
PROD_INPUT_BUCKET: recover-input-data
PROD_INTERMEDIATE_BUCKET: recover-intermediate-data
INTEGRATION_TEST_NUM_EXPORTS: 28
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Does it make sense to update to newer versions or is that a harder lift?

Copy link
Contributor Author

@rxu17 rxu17 Jul 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the problem is even the newest versions of the aws glue docker containers (glue 4.0) haven't been updated to use node 20 hence they all have node 16 / the glibc version 2.26 that the aws actions cannot accept because the aws actions use node 20 / glibc version >= 2.27.

The above would only be a temp. solution though. A more long term solution (until the above gets fixed) i was thinking of and mentioned in the discussion is by building Node.js statically so it doesn't matter what glibc version is used by the docker container. Not sure how viable this is yet so going to try it.


jobs:

Expand Down
Loading