[ETL-690] Add additional expectations for fitbit data types #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxu17
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Pre-approving!
I noticed that upload-and-deploy is not included in the build checks anymore
but it ran with an error here, that's different than error presented here.
philerooski
had a problem deploying
to
develop
GitHub Actions
Failure
philerooski
had a problem deploying
to
develop
GitHub Actions
Failure
philerooski
force-pushed
the
etl-690
branch
2 times, most recently
from
d1b22d2 to
4d857f3
Compare
philerooski
had a problem deploying
to
develop
GitHub Actions
Failure
philerooski
had a problem deploying
to
develop
GitHub Actions
Failure
This reverts commit bcfef0e.
That's strange. I can see upload-and-deploy. The workflow completes successfully now. |
|
Yup, it appears now for me - after your recent deployments/pushes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with the upload-and-deploy workflow that is causing tests to fail, which I've documented here: https://sagebionetworks.jira.com/browse/ETL-699There is no issue.
I was able to deploy this manually and did not have any issues generating validation docs for the additional data types. Additionally, I ran the tests which were prevented from running due to the issue mentioned above and they all passed (as expected -- there weren't any changes made to the code).