Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETL-562] Copy test data for integration testing #90

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

BryanFauble
Copy link
Contributor

Problem:
Previously we were manually creating test events to test the whole pipeline - instead we wanted the entire flow to handle this.

Solution:
Updating the integration test step to do an aws cp command to copy the test ingestion data

Testing:
See comment section of https://sagebionetworks.jira.com/browse/ETL-562 to see the whole flow having ran

@BryanFauble BryanFauble requested a review from a team as a code owner November 7, 2023 19:11
Copy link
Contributor

@philerooski philerooski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change.

.github/workflows/upload-and-deploy.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@rxu17 rxu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just a minor comment

.github/workflows/upload-and-deploy.yaml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants