Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(model-ad): generate Angular app for MODEL-AD #2679

Merged
merged 2 commits into from
May 15, 2024

Conversation

tschaffter
Copy link
Member

@tschaffter tschaffter commented May 15, 2024

Description

Generate an Angular app with Nx generator for MODEL-AD.

nx g @nx/angular:application model-ad-app \
  --directory apps/model-ad/app \
  --bundler esbuild \
  --ssr \
  --projectNameAndRootFormat as-provided \
  --dry-run

Notes

The generator also propose to add the VS Code extension firsttris.vscode-jest-runner. We are currently using another one that is more widely adopted by the community.

Preview

Start the app:

nx serve model-ad-app

image

Copy link

Quality Gate Passed Quality Gate passed for 'openchallenges-app'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'schematic-api'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'openchallenges-edam-etl'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'openchallenges-organization-service'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'openchallenges-challenge-service'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'openchallenges-image-service'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@tschaffter tschaffter marked this pull request as ready for review May 15, 2024 18:00
Copy link
Collaborator

@hallieswan hallieswan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to view the default start page after running nx serve model-ad-app in the remote devcontainer.

@tschaffter tschaffter merged commit 6aaa91c into Sage-Bionetworks:main May 15, 2024
8 of 9 checks passed
@tschaffter tschaffter deleted the model-ad/add-web-app branch May 15, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants