Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCHEMATIC-192] V24.12.1 into Main #1562

Merged
merged 105 commits into from
Dec 16, 2024
Merged

[SCHEMATIC-192] V24.12.1 into Main #1562

merged 105 commits into from
Dec 16, 2024

Conversation

andrewelamb
Copy link
Contributor

No description provided.

andrewelamb and others added 24 commits November 13, 2024 08:40
…tests

[FDS-2238, FDS-2236] Automate CLI test plan
…LI` commands from potentially erroring when doing a pip install (#1540)

* Make otel flash non-optional

* Add dependencies as non-optional
…test runs (#1550)

* Support exporting telemetry data from GH run via access token retrieved via oauth2
…Path module for checking cache size (#1542)

* Add version to click cli

* Add version

* Run black

* Reformat

* Fix

* Update schematic/schemas/data_model_parser.py

* Add test for check_synapse_cache_size

* Reformat

* Fix tests

* Remove unused parameter

* Install all-extras for now

* Make otel flash non-optional

* Update dockerfile

* Add dependencies as non-optional

* Update pyproject toml

* Fix trivy issue

* Add service version

* Run black

* Move all utils.general tests into separate folder

* Use pre-commit

* Add updates to contribution doc

* Fix

* Add service version to log provider

---------

Co-authored-by: BryanFauble <[email protected]>
* Set instance id in github CI run, uninstrument flask auto during integration test run
…ne doesn't have `entityId` (#1551)

* adds error handling

* adds unit tests for _get_file_entityIds

* updates error message

* adds entityid check to parent func

* updates docstring
source manifest file paths from synapse fileviews at generation
… with the NA values argument (#1553)

* Wrap pandas functions to support not including `None` with the NA values argument

* Ignore types

* pylint issues

* ordering of ignore

* Add to integration test to cover none in a manifest

* Add additional test for manifest

* [SCHEMATIC-210] Add attribute to nones data model (#1555)

Update example_test_nones.model.csv component and add new invalid manifest with nones

* first commit

* ran black

* add test for validateModelManifest

* [SCHEMATIC-214] change data model and component (#1556)

* add valid values to Patient attributes

* update data model

* add test manifests

* update test for new model

* update test for new valid value

* change test to use new manifests

* remove uneeded test file

* revert file

* revert file

* change tests to use new manifests

* remove uneeded manifests

* ran black

* add tests back in

* ran black

* revert manifest

* Split up valid and errored test as separate testing functions

* Remove unused import

---------

Co-authored-by: Gianna Jordan <[email protected]>
Co-authored-by: Andrew Lamb <[email protected]>
Co-authored-by: Thomas Yu <[email protected]>
@andrewelamb andrewelamb requested a review from a team as a code owner December 16, 2024 17:20
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM!

@thomasyu888 thomasyu888 changed the title V24.12.1 into Main [SCHEMATIC-192] V24.12.1 into Main Dec 16, 2024
Copy link

sonarcloud bot commented Dec 16, 2024

@andrewelamb andrewelamb merged commit 917236e into main Dec 16, 2024
8 checks passed
@andrewelamb andrewelamb deleted the v24.12.1-rc-dev branch December 16, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants