Merge pull request #555 from jay-hodgson/PORTALS-2844

PORTALS-2844
Sage-Bionetworks · Nov 8, 2023 · 68be39c · 68be39c
2 parents 77a7c78 + 53da2a2
commit 68be39c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/packages/synapse-react-client/src/components/TimelinePlot/TimelinePhase.tsx b/packages/synapse-react-client/src/components/TimelinePlot/TimelinePhase.tsx
@@ -24,7 +24,7 @@ const getTimepointData = (
 ): TimepointData => {
   let hoverOverIndex = -1
   const timepoints = rowData.map((row, index) => {
-    const time = parseInt(row.values[schema.time]!)
+    const time = parseFloat(row.values[schema.time]!)
     const timeUnit = row.values[schema.timeUnits]
     if (row.rowId == hoverEventRowId) {
       hoverOverIndex = index
@@ -53,7 +53,10 @@ export const getMaxDate = (timepoints: dayjs.Dayjs[]) => {
 
 const getTimelineData = (timepointData: TimepointData, rowData: Row[]) => {
   // If this phase has no data, return an empty data line
-  if (timepointData.timepoints.length == 0) {
+  if (
+    timepointData.timepoints == undefined ||
+    timepointData.timepoints.length == 0
+  ) {
     return [
       {
         x: [dayjs().format()],
@@ -220,7 +223,7 @@ const TimelinePhase = ({
   })
   const annotateTime =
     hoverRows && hoverRows.length > 0
-      ? parseInt(hoverRows[0].values[schema.time]!)
+      ? parseFloat(hoverRows[0].values[schema.time]!)
       : undefined
   const annotateTimeUnits =
     hoverRows && hoverRows.length > 0

diff --git a/packages/synapse-react-client/src/mocks/query/syn51735464.ts b/packages/synapse-react-client/src/mocks/query/syn51735464.ts
@@ -81,7 +81,7 @@ const syn51735464: QueryResultBundle = {
             'neonatal',
             'X',
             '999',
-            '8',
+            '8.5',
             'days',
             'Optic glioma, focal expansion of prechiasmatic optic nerves and chiasm. Low proliferative indices. Lack of eosinophilic granular bodies, Rosenthal fibers or microcystic structures commonly seen in humans (therefore not juvenile pilocytic astrocytomas). Decrease in IPL-GCL and RNFL thickness by SD-OCT',
             'pathologic',
-Original file line number
+Diff line change
@@ Expand Up / @@ -81,7 +81,7 @@ const syn51735464: QueryResultBundle = { @@
                 'neonatal',
                 'X',
                 '999',
-                '8',
+                '8.5',
                 'days',
                 'Optic glioma, focal expansion of prechiasmatic optic nerves and chiasm. Low proliferative indices. Lack of eosinophilic granular bodies, Rosenthal fibers or microcystic structures commonly seen in humans (therefore not juvenile pilocytic astrocytomas). Decrease in IPL-GCL and RNFL thickness by SD-OCT',
                 'pathologic',
@@ Expand Down @@