PORTALS-3307 - getting started component #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lakikowolfe
requested review from
nickgros and
jay-hodgson
and removed request for
nickgros
nickgros
requested changes
Dec 6, 2024
There was a problem hiding this comment.
I left a bunch of super nitpicky comments and optional suggestions, but as a whole what you have looks great and is pretty close to ready. I am mostly looking for code style changes and removal of the CSS properties that aren't doing anything. Please feel free to reach out if you have questions or want clarification
apps/synapse-portal-framework/src/components/elportal/ELGettingStarted.tsx
Outdated
Show resolved
Hide resolved
apps/synapse-portal-framework/src/components/elportal/ELGettingStarted.tsx
Outdated
Show resolved
Hide resolved
apps/synapse-portal-framework/src/components/elportal/ELGettingStarted.tsx
Outdated
Show resolved
Hide resolved
apps/synapse-portal-framework/src/components/elportal/ELGettingStarted.tsx
Outdated
Show resolved
Hide resolved
apps/synapse-portal-framework/src/components/elportal/ELGettingStarted.tsx
Outdated
Show resolved
Hide resolved
apps/synapse-portal-framework/src/components/elportal/ELGettingStarted.tsx
Outdated
Show resolved
Hide resolved
apps/synapse-portal-framework/src/components/elportal/ELGettingStarted.tsx
Show resolved
Hide resolved
apps/synapse-portal-framework/src/components/elportal/ELGettingStarted.tsx
Outdated
Show resolved
Hide resolved
apps/synapse-portal-framework/src/components/elportal/ELGettingStarted.tsx
Outdated
Show resolved
Hide resolved
apps/synapse-portal-framework/src/components/elportal/ELGettingStarted.tsx
Outdated
Show resolved
Hide resolved
|
hm something about merging main into this branch broke the site running locally. Looking into that now 👀 |
lakikowolfe
commented
Dec 9, 2024
apps/synapse-portal-framework/src/components/elportal/ELGettingStarted.tsx
Outdated
Show resolved
Hide resolved
apps/synapse-portal-framework/src/components/elportal/ELGettingStarted.tsx
Outdated
Show resolved
Hide resolved
apps/synapse-portal-framework/src/components/elportal/ELGettingStarted.tsx
Outdated
Show resolved
Hide resolved
apps/synapse-portal-framework/src/components/elportal/ELGettingStarted.tsx
Outdated
Show resolved
Hide resolved
nickgros
approved these changes
Dec 11, 2024
apps/synapse-portal-framework/src/components/elportal/ELGettingStarted.tsx
Outdated
Show resolved
Hide resolved
apps/synapse-portal-framework/src/components/elportal/ELGettingStarted.tsx
Outdated
Show resolved
Hide resolved
apps/synapse-portal-framework/src/components/elportal/ELGettingStarted.tsx
Show resolved
Hide resolved
apps/synapse-portal-framework/src/components/elportal/ELGettingStarted.tsx
Outdated
Show resolved
Hide resolved
apps/synapse-portal-framework/src/components/elportal/ELGettingStarted.tsx
Outdated
Show resolved
Hide resolved
solved by rebuilding repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a getting started component for the EL Portal
jira ticket: https://sagebionetworks.jira.com/browse/PORTALS-3307
I got this as close as I could to the figma mock up but to my eye it's still not quite right.