PORTALS-3361, PORTALS-3364 - Elite Portal scrub #1462
Merged
+16
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickgros
commented
Dec 16, 2024
Comment on lines
+9
to
+10
| export const studiesSql = | ||
| 'SELECT * FROM syn51523775 ORDER BY isFeatured DESC, dataStatus ASC, studyName ASC' |
There was a problem hiding this comment.
Update default sort for Studies. Currently, all studies have isFeatured=false. With this sort, studies with dataStatus=Available will be at the top, sorted in alphabetical order.
nickgros
commented
Dec 16, 2024
| @@ -150,10 +151,11 @@ export const studyDetailsPageRoutes: RouteObject[] = [ | |||
| shouldDeepLink={false} | |||
| defaultShowPlots={false} | |||
| lockedColumn={{ | |||
| columnName: 'study', | |||
| columnName: DATA_TABLE_COLUMN_NAMES.STUDY, | |||
There was a problem hiding this comment.
'study' column name in the data table was renamed to 'Study'
nickgros
commented
Dec 16, 2024
| value: value!, | ||
| }} | ||
| searchParams={{ study: value! }} | ||
| searchParams={{ [DATA_TABLE_COLUMN_NAMES.STUDY]: value! }} | ||
| fileIdColumnName={DATA_TABLE_COLUMN_NAMES.ID} |
There was a problem hiding this comment.
Ask was to show the access requirement status column. This is a Virtual Table, so we have to define the fileIdColumnName prop to show it.
nickgros
commented
Dec 16, 2024
| @@ -221,7 +221,7 @@ function FacetFilterControls(props: FacetFilterControlsProps) { | |||
|
|
|||
| return ( | |||
| <div className={`FacetFilterControls`}> | |||
| {combineRangeFacetConfig && ( | |||
| {combineRangeFacetConfig && combinedRangeFacets.length >= 2 && ( | |||
There was a problem hiding this comment.
Fix bug where combinedRangeFacets was defined but did not have enough elements, resulting in attempting to access properties on an undefined object
kianamcc
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.