SWC-7166 - Fix OrientationBanner display & add spreadSx utility #1463
+89
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickgros
commented
Dec 16, 2024
| @@ -54,9 +56,10 @@ function OrientationBanner(props: OrientationBannerProps) { | |||
| localStorage.getItem(storageBannerId) === null, | |||
| ) | |||
|
|
|||
| const theme = useTheme() | |||
| const defaultSx = { | |||
| display: { xs: 'none', md: 'unset' }, | |||
There was a problem hiding this comment.
Setting this to unset ended up replacing the flex layout, so we had to remove unset somehow
nickgros
commented
Dec 16, 2024
Comment on lines
+60
to
+62
| [theme.breakpoints.down('md')]: { | ||
| display: 'none', | ||
| }, |
There was a problem hiding this comment.
More concise/conventional way to just change the breakpoint styles is to do this. Now we aren't touching md and up.
nickgros
commented
Dec 16, 2024
| ...defaultSx, | ||
| ...sx, | ||
| }} | ||
| sx={spreadSx(defaultSx, sx)} |
There was a problem hiding this comment.
I learned that you can pass an array of SxProps to sx and MUI will handle merging them. This is more versatile/accurate than spreading objects because it allows using the function form of SxProps. I created a new utility to facilitate creating this array.
kianamcc
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
displayof OrientationBanner