Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYNPY-1517] Deprecate Python 3.8 Support #1134

Merged
merged 27 commits into from
Sep 26, 2024
Merged

[SYNPY-1517] Deprecate Python 3.8 Support #1134

merged 27 commits into from
Sep 26, 2024

Conversation

BWMac
Copy link
Contributor

@BWMac BWMac commented Sep 25, 2024 •
edited
Loading

Description:
This PR deprecates support for Python 3.8 in the Python Client. It also adjusts the pandas versions required in the project and removes the numpy version specification because we no longer have to allow for Python 3.8.

Documentation:
I have also updated the relevant documentation to no longer indicate support for Python 3.8.

I have done my best to find all of the places where documentation needs to be adjusted, but please let me know if I have missed anything.

@pep8speaks
Copy link

pep8speaks commented Sep 25, 2024 •
edited
Loading

Hello @BWMac! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-09-25 22:32:24 UTC

thomasyu888
thomasyu888 reviewed Sep 25, 2024
View reviewed changes
synapseutils/sync.py Outdated Show resolved Hide resolved
@BWMac BWMac marked this pull request as ready for review September 25, 2024 14:56
@BWMac BWMac requested a review from a team as a code owner September 25, 2024 14:56
jaymedina
jaymedina reviewed Sep 25, 2024
View reviewed changes
README.md Show resolved Hide resolved
@BWMac BWMac marked this pull request as draft September 25, 2024 16:28
@BWMac BWMac marked this pull request as ready for review September 25, 2024 19:28
@BWMac BWMac requested a review from thomasyu888 September 25, 2024 19:28
BryanFauble
BryanFauble reviewed Sep 25, 2024
View reviewed changes
setup.cfg Outdated Show resolved Hide resolved
BryanFauble
BryanFauble reviewed Sep 25, 2024
View reviewed changes
setup.cfg Outdated Show resolved Hide resolved
thomasyu888
thomasyu888 reviewed Sep 25, 2024
View reviewed changes
setup.cfg Outdated Show resolved Hide resolved
@BWMac BWMac requested a review from BryanFauble September 25, 2024 21:05
BryanFauble
BryanFauble approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating some of the docs I should have tackled when adding 3.12 :D

@BWMac BWMac merged commit 47e8709 into develop Sep 26, 2024
23 checks passed
@BWMac BWMac deleted the bwmac/SYNPY-1517/deprecate-3.8 branch September 26, 2024 00:52
@BWMac BWMac mentioned this pull request Sep 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasyu888 thomasyu888 thomasyu888 left review comments

@BryanFauble BryanFauble BryanFauble approved these changes

@jaymedina jaymedina Awaiting requested review from jaymedina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BWMac @pep8speaks @thomasyu888 @BryanFauble @jaymedina