Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FDS-2458] Attach the user.id of the logged in user to the trace span #1143

Merged
merged 2 commits into from
Oct 17, 2024
Merged

[FDS-2458] Attach the user.id of the logged in user to the trace span #1143

merged 2 commits into from
Oct 17, 2024

Conversation

BryanFauble
Copy link
Contributor

Problem:

  1. When the user ID is retrieved the data is not added to any trace, by providing this information we can use telemetry data to track a user action in the data.

Solution:

  1. When the credentials are retrieved attach the user.id if the span is being recorded.

Testing:

  1. I verified that the data is being passed along as expected:

image

@BryanFauble BryanFauble requested a review from a team as a code owner October 10, 2024 18:01
thomasyu888
thomasyu888 approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM!

@BryanFauble BryanFauble merged commit 162a058 into develop Oct 17, 2024
23 checks passed
@BryanFauble BryanFauble deleted the fds-2458-attach-user-id-to-span branch October 17, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasyu888 thomasyu888 thomasyu888 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BryanFauble @thomasyu888