Add procps to Dockerfile to enable use of container in Nextflow #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasyu888
reviewed
Nov 6, 2024
There was a problem hiding this comment.
I am ok with this, I'll defer to the team if they had any other ideas for adding this dependency
May want to finish discussions here first: https://sagebionetworks.slack.com/archives/C0AFCTGEQ/p1730887101702289?thread_ts=1730887101.702289&cid=C0AFCTGEQ
BryanFauble
approved these changes
Nov 6, 2024
Ah, let's merge then if marginal increase. @BryanFauble , thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a small change to the
Dockerfile. The change adds theprocpspackage to the list of installed packages.psfromprocpsis required by Nextflow. There are many use cases where having auto-built, latest version of synapsePythonClient in a Docker container will be valuable for users.Dockerfile: Addedprocpsto the list of installed packages.