Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tabs): reposition tab title on focus to prevent content moving on focus #7212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(tabs): reposition tab title on focus to prevent content moving on focus #7212

wants to merge 1 commit into from
+2 −1

Conversation

tomdavies73
Copy link
Contributor

@tomdavies73 tomdavies73 commented Feb 17, 2025 •
edited
Loading

Proposed behaviour

Adds top: 2px to the tab title to avoid the appearance of content moving

Current behaviour

Currently, content appears to move on focus due to a top: -2px value which is conditionally applied

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

@tomdavies73 tomdavies73 self-assigned this Feb 17, 2025
@tomdavies73 tomdavies73 requested a review from a team as a code owner February 17, 2025 16:37
@tomdavies73 tomdavies73 changed the title fix(tabs): make top -2px permanent for top position fix(tabs): reposition tab title on focus to prevent content moving on focus Feb 18, 2025
edleeks87
edleeks87 previously approved these changes Feb 18, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damienrobson-sage damienrobson-sage damienrobson-sage approved these changes

@edleeks87 edleeks87 edleeks87 left review comments

Assignees

@tomdavies73 tomdavies73

Labels
Passed Review Passed UX QA Pending QA Squad Front End
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomdavies73 @edleeks87 @damienrobson-sage @harpalsingh