Add fab button for sorting group items #30
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the
updateExpand
function, when I click on the fab button to update the sorting mode, the value ofgroup.isExpand
is not consistent withLibbox.newStandaloneCommandClient().setGroupExpand(group.tag, isExpand)
. This causes the expand state of the group to change back to its original state.sing-box-for-android/app/src/main/java/io/nekohasekai/sfa/ui/dashboard/GroupsFragment.kt
Lines 186 to 191 in e20fa63
The
group.isExpand
is synchronized by adding the following line, but I'm not sure if this is the behavior you want for the functionhttps://github.com/lgjint/sing-box-for-android/blob/74177358ed9f7ed0bde8187b81a84566a28da9d3/app/src/main/java/io/nekohasekai/sfa/ui/dashboard/GroupsFragment.kt#L201
Preview:
add-sort-button.mp4