Fix race condition in handling streams #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekohasekai
force-pushed
the
dev
branch
2 times, most recently
from
bb6a565
to
450d0d4
Compare
nekohasekai
force-pushed
the
dev
branch
3 times, most recently
from
82276c6
to
fe6153f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Stream object was created out of the for loop and it was being used in another goroutine, some race conditions were happening that caused some odd behaviors. For example a nil pointer was occurring on error.go:15 which is quite abnormal.
This pr successfully removes the race condition by initializing the stream object inside the loop and therefore exclusive for each goroutine.