Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ALPN settings #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stephanoskomnenos
Copy link

Fix ALPN not containing h3 in naive inbound when acme is on.

@stephanoskomnenos
Copy link
Author

ACME service pre-fills ALPN with a special value: https://github.com/caddyserver/certmagic/blob/master/config.go#L996
And h3 will not be prepended to server ALPN if it is not empty, causing handshake error.

@nekohasekai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants