Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid choose ZeroTier's tap to defaultInterface #4

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Avoid choose ZeroTier's tap to defaultInterface #4

wants to merge 1 commit into from

Conversation

wwqgtxx
Copy link
Contributor

@wwqgtxx wwqgtxx commented Oct 30, 2022

No description provided.

nekohasekai
nekohasekai requested changes Nov 3, 2022
View reviewed changes
monitor_windows.go
@@ -10,6 +11,10 @@ import (
"golang.org/x/sys/windows"
)

// zeroTierFakeGatewayIp from
// https://github.com/zerotier/ZeroTierOne/blob/1.8.6/osdep/WindowsEthernetTap.cpp#L994
var zeroTierFakeGatewayIp = netip.MustParseAddr("25.255.255.254")
Copy link
Member

@nekohasekai nekohasekai Nov 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to use a more general check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekohasekai nekohasekai nekohasekai requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wwqgtxx @nekohasekai