Apply lsp commands #1130
Merged
Apply lsp commands #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the lsp returns commands to run on completion, we now execute them. This is helpful for the Haskell language server which uses commands to implement auto-importing.
jhgarner
commented
Jan 31, 2025
lua/blink/cmp/sources/lsp/init.lua
Outdated
| function lsp:execute(_, item) | ||
| local client = vim.lsp.get_client_by_id(item.client_id) | ||
| if client and item.command then client.request('workspace/executeCommand', item.command) end | ||
| return function() end |
There was a problem hiding this comment.
I couldn't figure out what this returned function was supposed to do. The other example I saw returned an empty function so I return an empty one here as well. Let me know if something else should be happening instead.
2 tasks
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the lsp returns commands to run on completion, we now execute them. This is helpful for the Haskell language server which uses commands to implement auto-importing.