/render_resultsエンドポイントの追加
#212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us time index
This method would work like this:
|-- TIME_POINTS[0]
|
| |-- TIME_POINTS[1]
| |
| ||-- TIMEPOINT_END_MARGIN
| ||
| || |-- DRAWWING_TIME EXTENSION
| || |
| || | |-- Void time (annoucements, the show is going...)
| || | |
v index: x vv v v index: y index: z
|=============|-|******| |=============|-|******| |=============|-|
|++++++++++++++++++++++++++++++++|
|________________________________|
In the range of |+|, `get_prev_time_index` will return `x`.
In the range of |_|, `get_prev_time_index` will return `y`.
The diagram on the commit message was wrong, so DON'T PREFER TO IT. Instead, see notes. you can show notes by using: ``` git notes show 3fb5c1a ```
…dex' Test whether it fail when the time is out of acceptable range
…e edge of range If I do `ends[i] <= time <= ends[i+1]`, This expression will be True twice when `time` is the same as `ends[i+1]` because that would be the same as `ends[i] for the next expression. Of cource, this conflict won't work because of looping, But it is not good idea to leave things confusing, right? So I fixed it
'data' will be thrown to the jinja2 template
it's because the way generating PDF could be hard to do in such a limited time. I found that wkhtmltopdf doesn't treat CSS on alpine. It'll take more times to solve
…ture/183-generate-media-to-announce
houndci-bot
reviewed
Sep 14, 2018
scripts/draw_all.py
Outdated
| client = client() | ||
|
|
||
|
|
||
| id_list = load_id_json_file(Path(__file__).parent.parent / Path('cards/test_users.json')) |
There was a problem hiding this comment.
line too long (89 > 79 characters)
scripts/apply_ramdom.py
Outdated
| client = client() | ||
|
|
||
|
|
||
| id_list = load_id_json_file(Path(__file__).parent.parent/ Path('cards/test_users.json')) |
There was a problem hiding this comment.
missing whitespace around operator
line too long (88 > 79 characters)
|
Code Climate has analyzed commit 15875c2 and detected 0 issues on this pull request. View more on Code Climate. |
shino16
approved these changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
変更内容
発表用データを返す
/render_resultsエンドポイントを作成した各
TIMEPOINTS+1分(TIMEPOINT_END_MARGIN)後にアクセスすると、抽選結果が張り出せる形で出力されます。張り出しまでの流れ
/render-resultsにアクセスするPDFとして保存する(A0サイズで)発表用媒体(PDF, etc)を返すエンドポイントを作成 #183
修正前の挙動:
修正後の挙動:
影響範囲